Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUnique Ids for August entities to allow renames #20887
Conversation
homeassistant
added
component: august
small-pr
labels
Feb 9, 2019
wafflebot
bot
added
the
in progress
label
Feb 9, 2019
homeassistant
added
the
cla-signed
label
Feb 9, 2019
wonderslug
added some commits
Feb 9, 2019
wonderslug
added some commits
Feb 9, 2019
amelchio
approved these changes
Feb 10, 2019
Looks good! Just checking: what does the |
This comment has been minimized.
This comment has been minimized.
The august devices have a cloud id that is not directly related to the serial number. These ids come across as part of the protocol and would be fairly unique per cloud account, and probably across the august system as well. For the doorbell the doorbellID is used:
For the lock the lockID is used :
|
cgarwood
merged commit c3c9223
into
home-assistant:dev
Feb 11, 2019
wafflebot
bot
removed
the
in progress
label
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
wonderslug commentedFeb 9, 2019
Description:
This sets up unique ids on the august devices to allow for the devices to be used in the registry and support renames of them. This should be backwards compatible and does not effect the entity_id and name.
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests pass