Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Cache GTFS metadata and expose utility attributes (breaking change) #20966
Current sensor updates run 7 additional SQLite database queries to populate attributes, on top of the bus schedule queries themselves. Double that if you have two sensors. That leads to a lot of slowdowns for everything else when using an SD card!
Considering that some data never changes (agency, routes...) and that others like departure times are good until invalidated, let's fetch such metadata at first then only when relevant changes do occur.
Related issue (if applicable): fixes #21222
Mar 20, 2019
Mar 23, 2019
@robbiet480: I've rebased the branch and thanks to the recent merges I was able to make the following notable improvements from the previous state:
Mar 28, 2019
MartinHjelmare left a comment
Please open a new PR where we can address the comments.
For the future, please don't mix fixes, typing, features or other types of changes in the same PR. One type of change per PR and keep it as small as possible. Mixed changes like this is hard to review.
Will do! Indeed, this was a rather large-ish PR. I'll try to keep others in check.