Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xfinity Gateway device_tracker platform #21026

Merged
merged 8 commits into from Mar 5, 2019

Conversation

Projects
None yet
5 participants
@cisasteelersfan
Copy link
Contributor

commented Feb 13, 2019

Description:

Xfinity Gateway device_tracker platform. On the login page of the gateway, a list of connected devices with MAC address & hostname is displayed. My Pypi package scrapes this page using BeautifulSoup.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8535

Example entry for configuration.yaml (if applicable):

device_tracker:
  platform: xfinity

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@cisasteelersfan cisasteelersfan changed the title WIP Xfinity Gateway device_tracker platform Xfinity Gateway device_tracker platform Feb 13, 2019

Show resolved Hide resolved .coveragerc Outdated
@rohankapoorcom
Copy link
Member

left a comment

Overall looks good, a few small changes requested.

@cisasteelersfan cisasteelersfan force-pushed the cisasteelersfan:dev branch from 658c301 to 3db4a96 Feb 20, 2019

@cisasteelersfan cisasteelersfan force-pushed the cisasteelersfan:dev branch from 3db4a96 to c7d7aee Mar 4, 2019

@cisasteelersfan cisasteelersfan force-pushed the cisasteelersfan:dev branch 2 times, most recently from e53eba6 to 81cc9c9 Mar 4, 2019

@cisasteelersfan cisasteelersfan force-pushed the cisasteelersfan:dev branch from 81cc9c9 to 8739927 Mar 4, 2019

@rohankapoorcom
Copy link
Member

left a comment

Can be merged when build passes.

@MartinHjelmare
Copy link
Member

left a comment

Nice!

@rohankapoorcom rohankapoorcom merged commit 0e78054 into home-assistant:dev Mar 5, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 92.755%
Details

@ghost ghost removed the in progress label Mar 5, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.