Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use constants from #21068

merged 2 commits into from Feb 19, 2019


Copy link

fabaff commented Feb 14, 2019


  • Use CONF_ADDRESS and others from
  • Other minor changes (ordering, imports, file headers)


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

fabaff added some commits Feb 14, 2019

@fabaff fabaff force-pushed the conf-address branch from 2884d4e to fbbbc2b Feb 19, 2019

@fabaff fabaff merged commit 2d2c6cf into dev Feb 19, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@wafflebot wafflebot bot removed the in progress label Feb 19, 2019

@delete-merged-branch delete-merged-branch bot deleted the conf-address branch Feb 19, 2019

@balloob balloob referenced this pull request Mar 6, 2019


0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.