Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add traccar scan_interval configuration option #21079

Merged
merged 4 commits into from Feb 17, 2019

Conversation

Projects
None yet
5 participants
@lapy
Copy link
Contributor

commented Feb 14, 2019

Description:

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8618

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: traccar
    host: hostname
    port: 8072
    ssl: true
    username: admin
    password: password
    scan_interval: 00:00:05

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

commented Feb 14, 2019

Hi @lapy,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Feb 14, 2019

@home-assistant home-assistant deleted a comment from houndci-bot Feb 17, 2019

@MartinHjelmare MartinHjelmare removed the core label Feb 17, 2019

@MartinHjelmare MartinHjelmare changed the title Added scan_interval configuration option Add scan_interval configuration option Feb 17, 2019

@MartinHjelmare MartinHjelmare changed the title Add scan_interval configuration option Add traccar scan_interval configuration option Feb 17, 2019

@ludeeus

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2019

Wouldn't the interval_seconds from the device_tracker component give the same as this?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Feb 17, 2019

No, the traccar platform calls async_see to inform the component of seen devices. The component is not scanning for the traccar platform.

Update homeassistant/components/device_tracker/traccar.py
Co-Authored-By: lapy <lapy@users.noreply.github.com>
@ludeeus

This comment has been minimized.

Copy link
Contributor

commented Feb 17, 2019

Looks fine by me now, but I have been "out of the game" lately, so will let @MartinHjelmare continue his great job here :D

@lapy

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

Thanks to both of you! :)

Just a heads up: I have another pull request to do shortly after this is closed 😆

@MartinHjelmare
Copy link
Member

left a comment

Nice!

@MartinHjelmare MartinHjelmare merged commit 4e7cfc9 into home-assistant:dev Feb 17, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 17, 2019

@lapy lapy referenced this pull request Feb 18, 2019

Merged

Update traccar documentation with new parameters #8618

2 of 2 tasks complete

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.