Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hue retry crash #21083

Merged
merged 3 commits into from Feb 15, 2019

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

balloob commented Feb 15, 2019

Description:

If Hue would need to retry connection, subsequent tries would crash because we were using hass.data[DOMAIN] for both config and bridge. Also, if unloading and setting up same host again, the YAML config would be lost.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

balloob added some commits Feb 15, 2019

@balloob balloob merged commit 1130ccb into dev Feb 15, 2019

6 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.004%) to 92.785%
Details

@wafflebot wafflebot bot removed the in progress label Feb 15, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-hue-retry-crash branch Feb 15, 2019

balloob added a commit that referenced this pull request Feb 15, 2019

Fix hue retry crash (#21083)
* Fix Hue retry crash

* Fix hue retry crash

* Fix tests

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.