Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartThings Component Enhancements/Fixes #21085

Merged

Conversation

Projects
None yet
4 participants
@andrewsayre
Copy link
Contributor

andrewsayre commented Feb 15, 2019

Description:

Improves the SmartThings Component:

  • Displays specific error message to user when SmartThings cannot validate the webhook during setup (vs. generic error today)
  • Improves logging of errors received from the SmartThings API during component setup
  • Improves logging of push updates received
  • Fix so capabilities are not represented by more than one platform that covers the same data attribute.
    Prior to this change, Thermostats would show up as both the climate platform and 3-4 sensors -- but the sensors represent attributes already covered by the climate platform.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good!

@MartinHjelmare MartinHjelmare merged commit 93f84a5 into home-assistant:dev Feb 15, 2019

5 checks passed

Hound No violations found. Woof!
WIP ready for review
Details
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 92.806%
Details

@wafflebot wafflebot bot removed the in progress label Feb 15, 2019

@andrewsayre

This comment has been minimized.

Copy link
Contributor Author

andrewsayre commented Feb 15, 2019

Uhg! There's a bug! Apparently description_placeholders doesn't also populate error messages with a place holder. I don't see any error_placeholders implementation -- is this not supported? I'll need to remove the link from the new error message.

I can't get to this until this evening, so anyone is welcome to fix.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Feb 15, 2019

I'm not sure about this. @balloob?

@andrewsayre

This comment has been minimized.

Copy link
Contributor Author

andrewsayre commented Feb 15, 2019

Yeah and I added the placeholder after testing it, so shame on me for not retesting!!

@andrewsayre andrewsayre deleted the andrewsayre:smartthings-enhancements branch Feb 15, 2019

@andrewsayre andrewsayre added this to the 0.88.0 milestone Feb 17, 2019

balloob added a commit that referenced this pull request Feb 18, 2019

SmartThings Component Enhancements/Fixes (#21085)
* Improve component setup error logging/notification

* Prevent capabilities from being represented my multiple platforms

* Improved logging of received updates

* Updates based on review feedback

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.