Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated url pattern match support for static file hosting #21109

Conversation

Projects
None yet
3 participants
@awarecan
Copy link
Contributor

commented Feb 16, 2019

Description:

request review from @balloob

I think that logic is outdated, need balloob's confirmation

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@awarecan awarecan requested a review from home-assistant/core as a code owner Feb 16, 2019

@wafflebot wafflebot bot added the in progress label Feb 16, 2019

@balloob
Copy link
Member

left a comment

Good find!

@balloob balloob merged commit 2155a86 into home-assistant:dev Feb 17, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 92.801%
Details

@wafflebot wafflebot bot removed the in progress label Feb 17, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

@awarecan awarecan deleted the awarecan:remove-url-pattern-match-for-hosting-static-file branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.