Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix battery_level error - HomeKit #21120

Merged
merged 1 commit into from Feb 17, 2019

Conversation

Projects
None yet
3 participants
@cdce8p
Copy link
Member

commented Feb 16, 2019

Description:

Ignore battery level update in HomeKit if the value is not float convertible.

Related issue (if applicable): fixes #19701

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

Reported by: @maxandersen

@wafflebot wafflebot bot added the in progress label Feb 16, 2019

@cdce8p cdce8p added this to the 0.88.0 milestone Feb 16, 2019

@balloob balloob merged commit 9125e49 into home-assistant:dev Feb 17, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 92.804%
Details

@wafflebot wafflebot bot removed the in progress label Feb 17, 2019

balloob added a commit that referenced this pull request Feb 17, 2019

@cdce8p cdce8p deleted the cdce8p:homekit-battery-fix branch Feb 17, 2019

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.