Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person component: Handle ValueError #21126

Merged
merged 1 commit into from Feb 17, 2019

Conversation

Projects
None yet
3 participants
@balloob
Copy link
Member

commented Feb 16, 2019

Description:

Person component: Handle ValueError and render appropriate error message in frontend.

device_trackers=msg['device_trackers']
)
connection.send_result(msg['id'], person)
except ValueError as err:

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Feb 16, 2019

Member

When does it happen?

This comment has been minimized.

Copy link
@balloob

balloob Feb 16, 2019

Author Member

duplicate user id

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Feb 16, 2019

Member

Right. Delete person also raises ValueError.

@balloob balloob merged commit 9c92880 into dev Feb 17, 2019

4 of 5 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.007%) to 92.797%
Details

@wafflebot wafflebot bot removed the in progress label Feb 17, 2019

@delete-merged-branch delete-merged-branch bot deleted the person-fixes branch Feb 17, 2019

balloob added a commit that referenced this pull request Feb 17, 2019

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.