Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track_change error in utility_meter #21134

Merged
merged 2 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@dgomes
Copy link
Contributor

dgomes commented Feb 17, 2019

Description:

Python any() checks ALL member elements, this commit makes sure we return as soon as one of the states is None.

Related issue (if applicable): fixes #21122

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

utility_meter:
  daily_energy:
    source: sensor.aeotec_hem_kwh
    cycle: daily

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@dgomes dgomes added this to the 0.88.0 milestone Feb 17, 2019

@balloob balloob merged commit 3b5ed7a into home-assistant:dev Feb 18, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on utility_meter_none_state at 92.786%
Details

@wafflebot wafflebot bot removed the in progress label Feb 18, 2019

balloob added a commit that referenced this pull request Feb 18, 2019

Fix track_change error in utility_meter (#21134)
* split validation

* remove any()

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.