Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the google travel time update service #21153

Merged
merged 1 commit into from Feb 24, 2019

Conversation

Projects
None yet
3 participants
@rohankapoorcom
Copy link
Member

rohankapoorcom commented Feb 17, 2019

Description:

Per home-assistant/architecture#131, sensor platforms should not be registering services. google_travel_time is one of several that does and this should be cleaned up. This sensor has a service call which is used to manually update the sensor with the latest travel time.

Since there is now a service homeassistant.update that takes in one or more entity ids, the update service in this platform is redundant and now removed.

Breaking Change: The google_travel_time platform no longer has an update service, use homeassistant.update with the appropriate entity_id(s) instead.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8749

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@andrewsayre andrewsayre merged commit ce86fe4 into home-assistant:dev Feb 24, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.796%
Details

@wafflebot wafflebot bot removed the in progress label Feb 24, 2019

@rohankapoorcom rohankapoorcom deleted the rohankapoorcom:google-travel-time-update branch Feb 26, 2019

@rohankapoorcom rohankapoorcom referenced this pull request Feb 26, 2019

Merged

Remove the google travel time update service #8749

2 of 2 tasks complete

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

@ljmerza ljmerza referenced this pull request Mar 7, 2019

Closed

Refactor Waze Travel Time #21632

9 of 9 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.