Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HomematicIP Cloud fix cover position property #21154

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
4 participants
@mxworm
Copy link
Contributor

commented Feb 17, 2019

Description:

Fix cover position property

Checklist:

  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
@mxworm

This comment has been minimized.

Copy link
Contributor Author

commented Feb 17, 2019

@andrewsayre Can you please have a look on the complete implementation as for HmIP maps 0.0 = open and 1.0 = closed? I don't own such a device and most of the HmIP use hass.io - so only little beta test support :-)
With the last implementation the cover is moving the right direction but when it reaches the open position the arrow to close is greyed out and vice versa.

I missed to invert the current_cover_position, but is there something else as well?

Thanks Mattias

@andrewsayre
Copy link
Contributor

left a comment

I think that's it! I missed that too in the last one. Take WIP out and we can merge.

@mxworm mxworm changed the title [WIP] HomematicIP Cloud fix cover position property HomematicIP Cloud fix cover position property Feb 18, 2019

@andrewsayre andrewsayre merged commit 0b77a89 into home-assistant:dev Feb 18, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.796%
Details

@wafflebot wafflebot bot removed the in progress label Feb 18, 2019

@SukramJ

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2019

Hi @balloob,
could you please consider adding this PR to next minor release (0.88.x)?
It should fix the linked issues.

BR
Markus

@SukramJ

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2019

It's the missing part of a fix that is already in master.

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.