Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyEight for Python 3.7 Compatability #21161

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
5 participants
@mezz64
Copy link
Contributor

mezz64 commented Feb 18, 2019

Description:

Recent change to Python 3.7 in the docker container broke the pyEight library due to some old helper syntax. This increases the library version which has been updated to the new async/await syntax to work correctly with Python 3.7.
https://github.com/mezz64/pyEight/commits/master

Related issue (if applicable):

Pull request in home-assistant.io with documentation (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@Danielhiversen
Copy link
Member

Danielhiversen left a comment

Please add a link to the change log for pyEight

@Danielhiversen Danielhiversen merged commit 1afbc22 into home-assistant:dev Feb 18, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 18, 2019

@pvizeli pvizeli added this to the 0.88.0 milestone Feb 18, 2019

@mezz64

This comment has been minimized.

Copy link
Contributor Author

mezz64 commented Feb 18, 2019

Unfortunately, I don't currently maintain a formal change log. It's something I can do in the future. For now, the commit history syncs well with the releases and I try to keep them descriptive:
https://github.com/mezz64/pyEight/commits/master

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.