Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZHA fixes from beta feedback #21174

Merged

Conversation

Projects
None yet
5 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Feb 18, 2019

This PR cleans up a few small issues from the beta:

  • We will no longer configure reporting on several clusters that we shouldn't (more will be added in the future but this covers the most common ones)

  • We now grab the power profile from devices so that we can more intelligently grab fresh state / availability after a HA restart. Fixes #21148 As a result of this a small amount of work had to be done to clean up the way that listeners were created that we didn't also want to create sensors for.

@dmulcahey dmulcahey added this to the 0.88.0 milestone Feb 18, 2019

@dmulcahey dmulcahey requested a review from MartinHjelmare Feb 18, 2019

@homeassistant

This comment was marked as outdated.

Copy link

homeassistant commented Feb 18, 2019

Hello @dmulcahey,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Feb 18, 2019

Can be merged when CLA issue is fixed and build passes.

@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-device-powersource branch from d38c604 to 77b4d29 Feb 18, 2019

@homeassistant

This comment was marked as outdated.

Copy link

homeassistant commented Feb 18, 2019

Hello @dmulcahey,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

add power source to device and clean up listeners
check available and add comments

ensure order on API test

@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-device-powersource branch from 77b4d29 to 979df87 Feb 18, 2019

@dmulcahey dmulcahey removed the cla-error label Feb 18, 2019

@dmulcahey

This comment has been minimized.

Copy link
Contributor Author

dmulcahey commented Feb 18, 2019

@MartinHjelmare I think I fixed the CLA stuff.. can you peek quickly? New dev machine... causing all sorts of headaches :)

@MartinHjelmare MartinHjelmare merged commit 3f9e6a7 into home-assistant:dev Feb 18, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 92.796%
Details

@wafflebot wafflebot bot removed the in progress label Feb 18, 2019

balloob added a commit that referenced this pull request Feb 18, 2019

Add power source to device and clean up zha listeners (#21174)
check available and add comments

ensure order on API test

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.