Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rova component with suffix for house number #21182

Merged
merged 2 commits into from Feb 21, 2019

Conversation

Projects
None yet
5 participants
@GidoHakvoort
Copy link
Contributor

GidoHakvoort commented Feb 18, 2019

Add house_number_suffix to configuration

Description:

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8624

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: rova
    zip_code: ZIP_CODE
    house_number: HOUSE_NUMBER
    house_number_suffix: HOUSE_NUMBER_SUFFIX

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
Update rova component with release rova release 0.1.0
Add house_number_suffix to configuration

@wafflebot wafflebot bot added the in progress label Feb 18, 2019

GidoHakvoort added a commit to GidoHakvoort/home-assistant.io that referenced this pull request Feb 18, 2019

Add suffix to house_number
**Description:**

**Pull request in [home-assistant](https://github.com/home-assistant/home-assistant) (if applicable):** home-assistant/home-assistant#21182

@GidoHakvoort GidoHakvoort referenced this pull request Feb 18, 2019

Merged

Add suffix to house_number #8624

2 of 2 tasks complete
@Kane610
Copy link
Contributor

Kane610 left a comment

Looks good 👍

@GidoHakvoort GidoHakvoort reopened this Feb 19, 2019

@wafflebot wafflebot bot added in progress and removed in progress labels Feb 19, 2019

cgarwood added a commit to home-assistant/home-assistant.io that referenced this pull request Feb 21, 2019

Add suffix to house_number (#8624)
* Add suffix to house_number

**Description:**

**Pull request in [home-assistant](https://github.com/home-assistant/home-assistant) (if applicable):** home-assistant/home-assistant#21182

* Update sensor.rova.markdown

@cgarwood cgarwood merged commit e764d94 into home-assistant:dev Feb 21, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 21, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.