Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DHT and DS18B20 sensors via Konnected firmware #21189

Merged
merged 12 commits into from Mar 4, 2019

Conversation

Projects
None yet
5 participants
@heythisisnate
Copy link
Contributor

commented Feb 18, 2019

Description:

Adds support for digital sensors attached to a Konnected device. Currently the Konnected firmware supports DHT and DS18B20 sensors.

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8626

Example entry for configuration.yaml (if applicable):

konnected:
  access_token: CHANGEME
  devices:
    - id: dc4f223b1525
      sensors:
        - name: Outside
          type: dht
          pin: 6
        - name: Probe
          type: ds18b20
          pin: 7

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

heythisisnate added some commits Feb 18, 2019

Show resolved Hide resolved homeassistant/components/konnected/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/konnected/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/konnected/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/konnected/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/konnected/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/konnected/sensor.py Outdated
Show resolved Hide resolved homeassistant/components/konnected/sensor.py Outdated
@heythisisnate

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

@MartinHjelmare @pvizeli thank you for the great feedback. I learned a lot here. I've made the updates requested and it's a lot cleaner now. Would you mind taking another look?

@MartinHjelmare
Copy link
Member

left a comment

Very nice!

Show resolved Hide resolved homeassistant/components/konnected/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/konnected/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/konnected/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/konnected/__init__.py Outdated
@MartinHjelmare
Copy link
Member

left a comment

Looks good!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Can be merged when build passes.

@heythisisnate

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

could anyone help out with a merge?

@MartinHjelmare MartinHjelmare merged commit f62eb22 into home-assistant:dev Mar 4, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.06%) to 92.747%
Details

@ghost ghost removed the in progress label Mar 4, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.