Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that device trackers is always a list during creation #21193

Merged
merged 1 commit into from Feb 18, 2019

Conversation

Projects
None yet
5 participants
@balloob
Copy link
Member

commented Feb 18, 2019

Description:

We accidentally would set device trackers to None, causing an exception when we would update the state of a person.

reported by @dmulcahey

2019-02-18 15:49:23 ERROR (MainThread) [homeassistant.core] Error doing job: Exception in callback EventBus.async_listen_once.<locals>.onetime_listener(<Event homeassistant_start[L]>) at /Users/davidmulcahey/development/home-assistant/homeassistant/core.py:614
Traceback (most recent call last):
  File "/usr/local/Cellar/python/3.7.2_2/Frameworks/Python.framework/Versions/3.7/lib/python3.7/asyncio/events.py", line 88, in _run
    self._context.run(self._callback, *self._args)
  File "/Users/davidmulcahey/development/home-assistant/homeassistant/core.py", line 626, in onetime_listener
    self._hass.async_run_job(listener, event)
  File "/Users/davidmulcahey/development/home-assistant/homeassistant/core.py", line 333, in async_run_job
    target(*args)
  File "/Users/davidmulcahey/development/home-assistant/homeassistant/components/person/__init__.py", line 342, in person_start_hass
    self.person_updated()
  File "/Users/davidmulcahey/development/home-assistant/homeassistant/components/person/__init__.py", line 363, in person_updated
    self._update_state()
  File "/Users/davidmulcahey/development/home-assistant/homeassistant/components/person/__init__.py", line 374, in _update_state
    for entity_id in self._config.get(CONF_DEVICE_TRACKERS, []):
TypeError: 'NoneType' object is not iterable

@wafflebot wafflebot bot added the in progress label Feb 18, 2019

@balloob balloob merged commit 600070a into dev Feb 18, 2019

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA

@delete-merged-branch delete-merged-branch bot deleted the onboarding-bad-person branch Feb 18, 2019

@wafflebot wafflebot bot removed the in progress label Feb 18, 2019

@MartinHjelmare MartinHjelmare added this to the 0.88.2 milestone Feb 23, 2019

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

@balloob this wasn't tagged for 0.88, so never made it into the release.

@nirkons

This comment has been minimized.

Copy link

commented Mar 26, 2019

still having this error on 0.90.1 (relatively fresh installation)

Error doing job: Exception in callback <function EventBus.async_listen_once.<locals>.onetime_listener at 0x72b780c0>
Traceback (most recent call last):
  File "uvloop/cbhandles.pyx", line 64, in uvloop.loop.Handle._run
  File "/usr/local/lib/python3.7/site-packages/homeassistant/core.py", line 631, in onetime_listener
    self._hass.async_run_job(listener, event)
  File "/usr/local/lib/python3.7/site-packages/homeassistant/core.py", line 333, in async_run_job
    target(*args)
  File "/usr/local/lib/python3.7/site-packages/homeassistant/components/person/__init__.py", line 353, in person_start_hass
    self.person_updated()
  File "/usr/local/lib/python3.7/site-packages/homeassistant/components/person/__init__.py", line 374, in person_updated
    self._update_state()
  File "/usr/local/lib/python3.7/site-packages/homeassistant/components/person/__init__.py", line 385, in _update_state
    for entity_id in self._config.get(CONF_DEVICE_TRACKERS, []):
TypeError: 'NoneType' object is not iterable
@hadeshimself

This comment has been minimized.

Copy link

commented Mar 28, 2019

still having this error on 0.90.1 (relatively fresh installation)

Me too.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

Please open a new issue.

If you need help please use our help channels:
https://home-assistant.io/help/#communication-channels

Merged PRs should not be used for support or bug reports. Thanks!

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Mar 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.