Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ZHA listeners into channels #21196

Merged
merged 2 commits into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Feb 18, 2019

This PR renames listeners to channels and splits them up between modules that match the Zigpy module structure for clusters. The PR looks huge but there are actually 0 changes being introduced here. All that has been done is to rename "listener" to "channel" across ZHA and the listeners module has been reorganized into separate files. This will eventually be the foundation of full zigbee cluster support for ZHA.

The reason listeners are being renamed to channel is because not all clusters actually report anything. So in those cases (and in the end, the majority of the cases) listeners wouldn't actually be listening to anything. This makes the listener moniker break down so channel is a more appropriate name.

There are empty modules defined as placeholders. If this is a problem I can remove them but they will return shortly anyway...

There is NO need to include this in .88

dmulcahey added some commits Feb 18, 2019

@balloob balloob merged commit 3be8178 into home-assistant:dev Feb 19, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 19, 2019

@dmulcahey dmulcahey added this to the 0.88.0 milestone Feb 20, 2019

balloob added a commit that referenced this pull request Feb 20, 2019

Refactor ZHA listeners into channels (#21196)
* refactor listeners to channels

* update coveragerc

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Feb 21, 2019

Merge remote-tracking branch 'upstream/dev' into feature/discogs-v2
* upstream/dev: (948 commits)
  Prevent partial custom component overlays (home-assistant#21070)
  Alarm trigger support for Point (home-assistant#21207)
  Upgrade opensensemap-api to 0.1.4 (home-assistant#21240)
  Remove constraint from regex (home-assistant#21239)
  Updated frontend to 20190220.0
  Support OpenWRT 18.06 in luci device tracker (home-assistant#21236)
  Bump zigpy (home-assistant#21203)
  Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234)
  Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223)
  Add zone and reps for Xiaomi vacuum (home-assistant#19777)
  Fix an Ambient PWS exception when location info is missing (home-assistant#21220)
  Add self to integration sensor and utility_meter (home-assistant#21226)
  Prevent invalid context from crashing (home-assistant#21231)
  Update pyhomematic to 0.1.56 (home-assistant#21227)
  Fix the build (home-assistant#21229)
  Updated frontend to 20190219.0
  Add yeelight flow action support (home-assistant#21195)
  Refactor ZHA listeners into channels (home-assistant#21196)
  Fix Homematic IP Cloud configuration (home-assistant#21202)
  Push pyads to 3.0.7 (home-assistant#21216)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.