Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log entries were not ordered based on last occurrence #21200

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@dgomes
Copy link
Contributor

dgomes commented Feb 18, 2019

Description:

Reported by @gerard33 on discord #beta

"I have seen in 0.88.0b2 that the order of the log entries is not updated based on the time as shown here https://imgur.com/a/59G0GG7
The 1st and 2nd log entry arer at 7:13PM and the 3rd and 4th at 10:05PM (these are repetitive messages which are shown each 30 minutes). I would have expected these 3rd and 4th lines as first entries in the log based on the timestamp."

Related issue (if applicable): fixes #20493

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

system_log:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Feb 18, 2019

@dgomes dgomes added this to the 0.88.0 milestone Feb 18, 2019

@dgomes dgomes changed the title Fix log entries not order based on last occurrence Fix: log entries were not ordered based on last occurrence Feb 18, 2019

@dgomes dgomes changed the title Fix: log entries were not ordered based on last occurrence Fix log entries were not ordered based on last occurrence Feb 18, 2019

@balloob balloob merged commit b0f3177 into home-assistant:dev Feb 19, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 19, 2019

balloob added a commit that referenced this pull request Feb 19, 2019

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.