Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Homematic IP Cloud configuration #21202

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
3 participants
@bauerj
Copy link
Contributor

bauerj commented Feb 18, 2019

Description:

Currently, configuration of Homematic IP access points through the web interface is broken. Supplying correct information results in "Could not connect to HMIP server". The HMIP-Cloud authentication mechanism relies on the user pressing a button on their AP to pair the connecting device. Home Assistant's check whether that button was pressed is not working due to an upstream change:

homematicip.aio.auth.isRequestAcknowledged returns false if the request failed in stead of raising an error.

See coreGreenberet/homematicip-rest-api@0b61954

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

Closes: #20428

@homeassistant

This comment has been minimized.

Copy link

homeassistant commented Feb 18, 2019

Hi @bauerj,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Fix Homematic IP Cloud configuration
`homematicip.aio.auth.isRequestAcknowledged` returns false if the
request failed in stead of raising an error.

See coreGreenberet/homematicip-rest-api@0b61954

Closes: #20428

@bauerj bauerj force-pushed the bauerj:fix-homematicip-cloud branch from 58d8369 to 8a04869 Feb 19, 2019

@balloob balloob merged commit fe4a2b5 into home-assistant:dev Feb 19, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 19, 2019

Thanks

@wafflebot wafflebot bot removed the in progress label Feb 19, 2019

thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Feb 21, 2019

Merge remote-tracking branch 'upstream/dev' into feature/discogs-v2
* upstream/dev: (948 commits)
  Prevent partial custom component overlays (home-assistant#21070)
  Alarm trigger support for Point (home-assistant#21207)
  Upgrade opensensemap-api to 0.1.4 (home-assistant#21240)
  Remove constraint from regex (home-assistant#21239)
  Updated frontend to 20190220.0
  Support OpenWRT 18.06 in luci device tracker (home-assistant#21236)
  Bump zigpy (home-assistant#21203)
  Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234)
  Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223)
  Add zone and reps for Xiaomi vacuum (home-assistant#19777)
  Fix an Ambient PWS exception when location info is missing (home-assistant#21220)
  Add self to integration sensor and utility_meter (home-assistant#21226)
  Prevent invalid context from crashing (home-assistant#21231)
  Update pyhomematic to 0.1.56 (home-assistant#21227)
  Fix the build (home-assistant#21229)
  Updated frontend to 20190219.0
  Add yeelight flow action support (home-assistant#21195)
  Refactor ZHA listeners into channels (home-assistant#21196)
  Fix Homematic IP Cloud configuration (home-assistant#21202)
  Push pyads to 3.0.7 (home-assistant#21216)
  ...

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.