Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for latest Harmony firmware version 4.15.250 #21213

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
6 participants
@ehendrix23
Copy link
Contributor

ehendrix23 commented Feb 19, 2019

Description:

Update aioharmony version to 0.1.8 to support latest HUB firmware (4.15.250).
Breaking change, with this version the older HUB firmware versions are not supported anymore.

Related issue (if applicable): fixes #21191

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
Set aioharmony version to 0.1.8
Update aioharmony version to support latest HUB firmware (4.15.250).
@amelchio

This comment has been minimized.

Copy link
Contributor

amelchio commented Feb 19, 2019

If old firmwares are not supported anyway and we want to go to XMPP eventually, maybe we should just revert to pyharmony for now?

@ehendrix23

This comment has been minimized.

Copy link
Contributor Author

ehendrix23 commented Feb 19, 2019

Then you also need to revert harmony.py in HA as pyharmony is not asyncio.

@amelchio

This comment has been minimized.

Copy link
Contributor

amelchio commented Feb 19, 2019

Yes. It is not async but it also does not have known issues and it is expected to not break again. So it would make sense to me to use that until the async xmpp is ready.

@ehendrix23

This comment has been minimized.

Copy link
Contributor Author

ehendrix23 commented Feb 19, 2019

HA 0.86 fixed issue with reconnect. This one also includes a fix that Sean was having on connection by not requesting things from HUB in parallel but rather do it sequential (for some reason he had 2 HUBs having issues with this, 1 did not; the 2 I have never have an issue with this).

Other issues so far have always been something with network instabilities. Seems to be especially on HASSIO but haven't completely been able to narrow it down. I've been helping someone else with similar issue also on HASSIO with network issues (i.e. host unreachable, dropped connections). Thus not sure if going back to XMPP will really help these cases as it seems to do with inability to keep sockets open. Just haven't been able to get really down to root cause for these.

@dshokouhi

This comment has been minimized.

Copy link
Contributor

dshokouhi commented Feb 19, 2019

Just an FYI but since the below bug was introduced and does not go away I have personally reverted back to pyharmony as a custom component and found it to be extremely stable for me requiring 0 intervention to fix.

#20002

I do not have any issues with a hub going unavailable since I reverted and it has always worked with XMPP firmware. I don't think any of the connection issues were there before we switched so for me the old code is much more stable. I have personally tried the latest updates but one of my hubs always goes unavailable after some time.

I agree with @amelchio here since Harmony has reverted back to XMPP maybe we should to? The unavailable issues are a show stopper in many installations as it halts automations until it is resolved. I get not everyone has those issues but they were non-existent prior to the current implementation.

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 19, 2019

I agree that we should switch to an API that is official. But it's out of scope for this PR, as this will allow people to start using Harmony again.

@balloob balloob merged commit 99eda38 into home-assistant:dev Feb 19, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 19, 2019

@amelchio

This comment has been minimized.

Copy link
Contributor

amelchio commented Feb 19, 2019

Not quite out of scope, I think, since the implication was that we should not merge this PR.

Now we get two breaking changes and not just one.

@ehendrix23

This comment has been minimized.

Copy link
Contributor Author

ehendrix23 commented Feb 19, 2019

Reverting back to pyharmony would also mean right now reverting back the HA harmony. That would be a breaking change as the service change_channel would not be in there.

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 19, 2019

@amelchio ah I guess you're right. But with this PR, all users of Harmony can get to a working version by upgrading to latest firmware. In the pre-this-pr-world, some people had already upgraded and had a no longer working system.

balloob added a commit that referenced this pull request Feb 19, 2019

Set aioharmony version to 0.1.8 (#21213)
Update aioharmony version to support latest HUB firmware (4.15.250).

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

@ronytomen

This comment has been minimized.

Copy link

ronytomen commented Feb 21, 2019

@balloob Appreciate this being merged. Also, moving back to the XMPP API will require end users to change the setting on the Harmony Hub via the iOS or Android app. A warning in the logs should be sufficient to prompt people to update the setting.

@ehendrix23 ehendrix23 deleted the ehendrix23:Harmony-Support-4.15.250 branch Feb 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.