Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push pyads to 3.0.7 #21216

Merged
merged 7 commits into from Feb 19, 2019

Conversation

Projects
None yet
5 participants
@carstenschroeder
Copy link
Contributor

carstenschroeder commented Feb 19, 2019

Description:

ADS component did not work under Hass.io. pyads 3.0.7 corrects build issues under Alpine Linux. Minor adjustment were needed to adapt component to new release.

Related issue (if applicable): fixes home-assistant/hassio-homeassistant#25

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

carstenschroeder added some commits Dec 30, 2018

_LOGGER.error(
"Could not connect to ADS host (netid=%s, port=%s)", net_id, port)
"Could not connect to ADS host (netid=%s, ip=%s, port=%s)", net_id, ip_address, port)

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Feb 19, 2019

line too long (97 > 79 characters)

@carstenschroeder

This comment has been minimized.

Copy link
Contributor Author

carstenschroeder commented Feb 19, 2019

@MartinHjelmare Could you have a look at this PR? It's a bugfix to enable ADS on Hass.io.

@MartinHjelmare MartinHjelmare added this to the 0.88.0 milestone Feb 19, 2019

@MartinHjelmare MartinHjelmare merged commit df8589c into home-assistant:dev Feb 19, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 19, 2019

@carstenschroeder carstenschroeder deleted the carstenschroeder:push-pyads-to-3.0.7 branch Feb 19, 2019

balloob added a commit that referenced this pull request Feb 19, 2019

Push pyads to 3.0.7 (#21216)
* Push to pyads 3.0.7

* Correct too long line

@balloob balloob referenced this pull request Feb 20, 2019

Merged

0.88.0 #21238

thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Feb 21, 2019

Merge remote-tracking branch 'upstream/dev' into feature/discogs-v2
* upstream/dev: (948 commits)
  Prevent partial custom component overlays (home-assistant#21070)
  Alarm trigger support for Point (home-assistant#21207)
  Upgrade opensensemap-api to 0.1.4 (home-assistant#21240)
  Remove constraint from regex (home-assistant#21239)
  Updated frontend to 20190220.0
  Support OpenWRT 18.06 in luci device tracker (home-assistant#21236)
  Bump zigpy (home-assistant#21203)
  Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234)
  Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223)
  Add zone and reps for Xiaomi vacuum (home-assistant#19777)
  Fix an Ambient PWS exception when location info is missing (home-assistant#21220)
  Add self to integration sensor and utility_meter (home-assistant#21226)
  Prevent invalid context from crashing (home-assistant#21231)
  Update pyhomematic to 0.1.56 (home-assistant#21227)
  Fix the build (home-assistant#21229)
  Updated frontend to 20190219.0
  Add yeelight flow action support (home-assistant#21195)
  Refactor ZHA listeners into channels (home-assistant#21196)
  Fix Homematic IP Cloud configuration (home-assistant#21202)
  Push pyads to 3.0.7 (home-assistant#21216)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.