Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Add ADB server functionality to Fire TV #21221
Allow for using an ADB server instance, such as the Hass.io ADB addon, with the Fire TV component.
This is a breaking change, as it removes the
This includes the changes in #21131.
Related issue (if applicable):
Example entry for
referenced this pull request
Feb 19, 2019
@rytilahti, @bachya, @MartinHjelmare could I please get a review for this pull request. I've tested the code, as have a number of users on the forum, and it works fine. The significance of this pull request is that by allowing the Fire TV component to use an ADB server, such as @frenck's addon, it enables the component to work for newer devices that the Python ADB implementation can't handle. It would be great to have this functionality in the built-in component instead of users needing to deal with a custom component and its dependencies.
rytilahti left a comment
Nice to see device specific parts being moved out into the library!
I tested this briefly with my firetv stick and it seems to be working fine, I'm not sure if the active source ever worked, but I'm receiving this warning (
@rytilahti thanks for the review! I can change those comments later.
Here's the line in the
The command executed successfully, but the output wasn't what it expected. I don't know enough about the Fire TV inner workings to say why it didn't work. I could:
@JeffLIrion I don't know why the current focus was null in that case, I thought it could have been due to a popup from an app asking whether to continue where it was left the last time or to start the episode from the beginning. However, I just tested it out manually with
I suppose there is not much to be done in case the device does not report the active focus for a reason for another -- displaying a warning in the logs is fine for me.