Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ZHA and tweak non sensor channel logic #21234

Merged
merged 2 commits into from Feb 20, 2019

Conversation

Projects
None yet
5 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Feb 20, 2019

This PR fixes a race condition in device availability logic and it tweaks the logic for non sensor zigbee channels to prevent them from being "stolen" by profiles and it fixes an attribute name in the channel responsible for battery data.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Feb 20, 2019

Can and should we tag this for 0.88?

@dmulcahey

This comment has been minimized.

Copy link
Contributor Author

dmulcahey commented Feb 20, 2019

@MartinHjelmare I would like to but that means we would have to pull in another that wasn't tagged or in the beta: #21196

@dmulcahey dmulcahey added this to the 0.88.0 milestone Feb 20, 2019

@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Feb 20, 2019

@dmulcahey please remove this two lines in a future PR:

SENSOR_TYPES = {}
BINARY_SENSOR_TYPES = {}

Globals are not allowed. Use hass.data

@pvizeli pvizeli removed this from the 0.88.0 milestone Feb 20, 2019

@pvizeli pvizeli merged commit cece645 into home-assistant:dev Feb 20, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.803%
Details

@wafflebot wafflebot bot removed the in progress label Feb 20, 2019

@dmulcahey

This comment has been minimized.

Copy link
Contributor Author

dmulcahey commented Feb 20, 2019

@pvizeli why was this removed from the .88 milestone?

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Feb 20, 2019

Adding it back to the milestone - this was discussed between @dmulcahey and me (and then not properly communicated)

@balloob balloob added this to the 0.88.0 milestone Feb 20, 2019

balloob added a commit that referenced this pull request Feb 20, 2019

Fix bug in ZHA and tweak non sensor channel logic (#21234)
* fix race condition and prevent profiles from stealing channels

* fix battery voltage

thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Feb 21, 2019

Merge remote-tracking branch 'upstream/dev' into feature/discogs-v2
* upstream/dev: (948 commits)
  Prevent partial custom component overlays (home-assistant#21070)
  Alarm trigger support for Point (home-assistant#21207)
  Upgrade opensensemap-api to 0.1.4 (home-assistant#21240)
  Remove constraint from regex (home-assistant#21239)
  Updated frontend to 20190220.0
  Support OpenWRT 18.06 in luci device tracker (home-assistant#21236)
  Bump zigpy (home-assistant#21203)
  Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234)
  Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223)
  Add zone and reps for Xiaomi vacuum (home-assistant#19777)
  Fix an Ambient PWS exception when location info is missing (home-assistant#21220)
  Add self to integration sensor and utility_meter (home-assistant#21226)
  Prevent invalid context from crashing (home-assistant#21231)
  Update pyhomematic to 0.1.56 (home-assistant#21227)
  Fix the build (home-assistant#21229)
  Updated frontend to 20190219.0
  Add yeelight flow action support (home-assistant#21195)
  Refactor ZHA listeners into channels (home-assistant#21196)
  Fix Homematic IP Cloud configuration (home-assistant#21202)
  Push pyads to 3.0.7 (home-assistant#21216)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.