Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenWRT 18.06 in luci device tracker #21236

Merged
merged 2 commits into from Feb 20, 2019

Conversation

Projects
None yet
3 participants
@fbradyirl
Copy link
Collaborator

commented Feb 20, 2019

Description:

Updating luci rpc device tracker to use new APIs in OpenWRT 18.06.

As recommended in the old PR #15792 , I have moved RPC logic into a pip module called openwrt-luci-rpc

This is a retake of the PR #21233 which got messed up with the wrong CLA email in one commit. (apologies about that!)

Related issue (if applicable): fixes #8508

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@MartinHjelmare
Copy link
Member

left a comment

Just a couple of things left to fix.

Show resolved Hide resolved homeassistant/components/device_tracker/luci.py Outdated
Show resolved Hide resolved homeassistant/components/device_tracker/luci.py Outdated

@MartinHjelmare MartinHjelmare removed the core label Feb 20, 2019

@fbradyirl

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 20, 2019

Thanks @MartinHjelmare I appreciate the time spent on this review.

@MartinHjelmare
Copy link
Member

left a comment

Great!

@MartinHjelmare MartinHjelmare merged commit 54949cf into home-assistant:dev Feb 20, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.805%
Details

@wafflebot wafflebot bot removed the in progress label Feb 20, 2019

@fbradyirl fbradyirl deleted the fbradyirl:luciRpcFixTake2 branch Feb 20, 2019

thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Feb 21, 2019

Merge remote-tracking branch 'upstream/dev' into feature/discogs-v2
* upstream/dev: (948 commits)
  Prevent partial custom component overlays (home-assistant#21070)
  Alarm trigger support for Point (home-assistant#21207)
  Upgrade opensensemap-api to 0.1.4 (home-assistant#21240)
  Remove constraint from regex (home-assistant#21239)
  Updated frontend to 20190220.0
  Support OpenWRT 18.06 in luci device tracker (home-assistant#21236)
  Bump zigpy (home-assistant#21203)
  Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234)
  Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223)
  Add zone and reps for Xiaomi vacuum (home-assistant#19777)
  Fix an Ambient PWS exception when location info is missing (home-assistant#21220)
  Add self to integration sensor and utility_meter (home-assistant#21226)
  Prevent invalid context from crashing (home-assistant#21231)
  Update pyhomematic to 0.1.56 (home-assistant#21227)
  Fix the build (home-assistant#21229)
  Updated frontend to 20190219.0
  Add yeelight flow action support (home-assistant#21195)
  Refactor ZHA listeners into channels (home-assistant#21196)
  Fix Homematic IP Cloud configuration (home-assistant#21202)
  Push pyads to 3.0.7 (home-assistant#21216)
  ...

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.