Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZHA bugs #21246

Merged
merged 3 commits into from Feb 21, 2019

Conversation

Projects
None yet
4 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Feb 21, 2019

this should fix 2 reported issues from .88 release:

fixes #21243 - we won't flood the network with requests if we can't determine power profiles
fixes #21245 - added manufacturer specific cluster support back in but in a more generic way

dmulcahey added some commits Feb 21, 2019

@pvizeli

This comment has been minimized.

Copy link
Member

pvizeli commented Feb 21, 2019

There was the reason why we don't should push changes directly to stable @balloob

@dmulcahey

This comment has been minimized.

Copy link
Contributor Author

dmulcahey commented Feb 21, 2019

@pvizeli these are additional changes and not related to the 2 fixes that were added yesterday. If anything, we would have had more issues to deal with if they weren’t included. This is easy enough to see if you look at the actual code changed instead of trying to make a point.

edit now that i'm awake w/ some caffeine in my system...

I'm going to leave another note here for anyone who cares to read it. Who knows, maybe a blog post on this would be good... Something we need to realize as a community is that a lot of the development here is done by people who are donating their time because they enjoy doing this and they enjoy helping people. In the end we're all entitled to our opinions on processes and how things should work. That said, they should be handled in the appropriate forum. Also, the space we are operating in is massively complex. This platform moves at an incredible pace that other platforms (and companies) can only envy. Things are going to break... it's bound to happen. We should focus on fixing them and not "I told you so" or slapping the people who are acting in the best interest of the community as a whole.

We're all working to make this platform a great platform! Grievances, dirty laundry, disagreements etc. are better left for discord or other communication mediums IMO unless they are specific to a piece of code that belongs to a PR. Otherwise, we risk alienating / disengaging people who are giving their time to make this platform the best it can be and it also takes away from the point of an issue / PR in the first place (even though I'm doing it myself now...)

I'm not going anywhere :) you guys are stuck with me now but I wanted to drop this note because I have seen several instances of this lately and I even did it myself accidentally last evening: #21243 (comment)

I'm not sure we (devs in general, not just the HA community) take enough time to look at the big picture and realize that most people are contributing to OSS or opening issues because they want to make things better for everyone.

I won't leave or reply to comments like this one or the one above on issues / PR's in the future and maybe that's something we should all consider doing :)

@@ -36,6 +36,7 @@

SENSOR_TYPES = {}
BINARY_SENSOR_TYPES = {}

This comment has been minimized.

Copy link
@pvizeli

pvizeli Feb 21, 2019

Member

That is not relevant for this PR, but globals are not allowed. Please migrate this in a future PR to hass.data or as a member inside gateway object.

@pvizeli pvizeli merged commit 0f8575f into home-assistant:dev Feb 21, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.003%) to 92.806%
Details

@wafflebot wafflebot bot removed the in progress label Feb 21, 2019

balloob added a commit that referenced this pull request Feb 22, 2019

Fix ZHA bugs (#21246)
* fix bugs

* add comment

* allow entities to be marked unavailable

@balloob balloob referenced this pull request Feb 22, 2019

Merged

0.88.1 #21296

@home-assistant home-assistant deleted a comment Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.