Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python-anthemav to v1.1.9 #21273

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
6 participants
@nugget
Copy link
Contributor

commented Feb 21, 2019

Description:

Version bump of underlying python-anthemav library to 1.1.9. This fixes a syntax error in Python 3.7 where async has become a reserved word.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@fabaff fabaff changed the title Version bump: python-anthemav to v1.1.9 Upgrade python-anthemav to v1.1.9 Feb 21, 2019

@fabaff

fabaff approved these changes Feb 21, 2019

@fabaff fabaff merged commit d9a44f2 into home-assistant:dev Feb 21, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on anthemav-version-bump at 92.807%
Details

@wafflebot wafflebot bot removed the in progress label Feb 21, 2019

@nugget nugget deleted the nugget:anthemav-version-bump branch Feb 21, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

@twochannel

This comment has been minimized.

Copy link

commented Mar 7, 2019

This did not seem to resolve the issue in 89.0, still getting the asyncio error.

Should I open a new issue here or with the underlying anthemav module.

Log Details (ERROR)
Thu Mar 07 2019 18:31:39 GMT-0500 (Eastern Standard Time)
Error while setting up platform anthemav
Traceback (most recent call last):
  File "/usr/src/app/homeassistant/helpers/entity_platform.py", line 128, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/local/lib/python3.7/asyncio/tasks.py", line 416, in wait_for
    return fut.result()
  File "/usr/src/app/homeassistant/components/media_player/anthemav.py", line 42, in async_setup_platform
    import anthemav
  File "/usr/local/lib/python3.7/site-packages/anthemav/__init__.py", line 6, in <module>
    from .connection import Connection      # noqa: F401
  File "/usr/local/lib/python3.7/site-packages/anthemav/connection.py", line 4, in <module>
    from .protocol import AVR
  File "/usr/local/lib/python3.7/site-packages/anthemav/protocol.py", line 12
    ensure_future = asyncio.async
                                ^
SyntaxError: invalid syntax
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

Please open new issues.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Mar 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.