Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unhandled exception in Ambient PWS config entry #21278

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
3 participants
@bachya
Copy link
Contributor

bachya commented Feb 21, 2019

Description:

If the ambient_station component is set up as a config entry, an exception gets thrown due to a reliance on configuration.yaml values; this PR fixes that.

Related issue (if applicable): fixes #21255

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

ambient_station:
  api_key: !secret ambient_pws_api_key
  app_key: !secret ambient_pws_app_key

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@bachya bachya added this to the 0.88.1 milestone Feb 21, 2019

@bachya bachya self-assigned this Feb 21, 2019

@wafflebot wafflebot bot added the in progress label Feb 21, 2019

@bachya bachya merged commit d0e88d9 into home-assistant:dev Feb 21, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Feb 21, 2019

@bachya bachya deleted the bachya:ambient-fix branch Feb 21, 2019

balloob added a commit that referenced this pull request Feb 22, 2019

@balloob balloob referenced this pull request Feb 22, 2019

Merged

0.88.1 #21296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.