Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not warn for internally loaded components #21287

Merged
merged 1 commit into from Feb 21, 2019

Conversation

Projects
None yet
4 participants
@balloob
Copy link
Member

balloob commented Feb 21, 2019

Description:

In #21070 I made a mistake by using the externally facing get_component inside get_platform, causing a warning to be printed for errors that were expected.

This fixes it. It also fixes the custom component warning.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Feb 21, 2019

@wafflebot wafflebot bot added the in progress label Feb 21, 2019

@balloob balloob merged commit ac50298 into dev Feb 21, 2019

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Feb 21, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-fake-warnings branch Feb 21, 2019

@SukramJ

This comment has been minimized.

Copy link
Contributor

SukramJ commented Feb 22, 2019

I think this PR causes a lint in dev:
homeassistant/loader.py:163:8: W0612: Unused variable 'index' (unused-variable)

Thats why my PR build #21241 fails in travis. Others are affected too.

@fabaff fabaff referenced this pull request Feb 22, 2019

Merged

Remove index #21304

1 of 1 task complete

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.