Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yeelight config validation #21295

Merged
merged 1 commit into from Feb 22, 2019

Conversation

Projects
None yet
2 participants
@balloob
Copy link
Member

balloob commented Feb 22, 2019

Description:

YeeLight had an incorrect config schema, causing incorrect warnings to be triggered. Updated config validation to match docs + what the code expects.

Related issue (if applicable): fixes #21293

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob added this to the 0.88.1 milestone Feb 22, 2019

@balloob balloob requested a review from rytilahti as a code owner Feb 22, 2019

@wafflebot wafflebot bot added the in progress label Feb 22, 2019

@balloob balloob merged commit bf4fb36 into dev Feb 22, 2019

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA

@wafflebot wafflebot bot removed the in progress label Feb 22, 2019

@delete-merged-branch delete-merged-branch bot deleted the fix-yeelight-validation branch Feb 22, 2019

balloob added a commit that referenced this pull request Feb 22, 2019

@balloob balloob referenced this pull request Feb 22, 2019

Merged

0.88.1 #21296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.