Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple devices for PS4 component #21302

Merged
merged 48 commits into from Mar 5, 2019

Conversation

Projects
None yet
5 participants
@ktnrg45
Copy link
Contributor

ktnrg45 commented Feb 22, 2019

Description:

Added support for the use of multiple PS4 devices. Additional devices can be added by starting the ps4 config flow again.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8679

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@wafflebot wafflebot bot added the in progress label Feb 22, 2019

@ktnrg45 ktnrg45 referenced this pull request Feb 22, 2019

Merged

Add multiple device support in docs #8679

2 of 2 tasks complete
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Also test one entry with one device and then configuring another device for the entry.

Show resolved Hide resolved homeassistant/components/ps4/config_flow.py Outdated

@ktnrg45 ktnrg45 changed the title Add support for multiple devices on PS4 component. Add support for multiple devices for PS4 component. Feb 22, 2019

@fabaff fabaff changed the title Add support for multiple devices for PS4 component. Add support for multiple devices for PS4 component Feb 23, 2019

ktnrg45 added some commits Feb 21, 2019

Revert "Support multiple devices."
This reverts commit 3f5d446.
fix
@ktnrg45

This comment has been minimized.

Copy link
Contributor Author

ktnrg45 commented Feb 27, 2019

@MartinHjelmare Should be good now.

ktnrg45 added some commits Mar 1, 2019

@ktnrg45

This comment has been minimized.

Copy link
Contributor Author

ktnrg45 commented Mar 3, 2019

@MartinHjelmare Removed loop. Ready for another review.

ktnrg45 added some commits Mar 3, 2019

ktnrg45 added some commits Mar 4, 2019

with patch('pyps4_homeassistant.Helper.port_bind',
return_value=None):
result = await flow.async_step_user()
assert result['type'] == data_entry_flow.RESULT_TYPE_FORM

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Mar 4, 2019

Member

The result assertions can be moved out of the context manager indentation.

Show resolved Hide resolved tests/components/ps4/test_config_flow.py Outdated
Show resolved Hide resolved tests/components/ps4/test_config_flow.py Outdated
Show resolved Hide resolved tests/components/ps4/test_config_flow.py Outdated
@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Good! Can be merged when build passes.

@ktnrg45

This comment has been minimized.

Copy link
Contributor Author

ktnrg45 commented Mar 5, 2019

Good! Can be merged when build passes.

Cool! Thanks.

@MartinHjelmare MartinHjelmare merged commit efa5d5d into home-assistant:dev Mar 5, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Mar 5, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

@ktnrg45 ktnrg45 deleted the ktnrg45:ps4-multiple-devices branch Mar 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.