Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove index #21304

Merged
merged 2 commits into from Feb 22, 2019

Conversation

Projects
None yet
5 participants
@fabaff
Copy link
Member

commented Feb 22, 2019

Description:

Remove index.

Fixes error introduces by #21287.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@fabaff fabaff requested a review from home-assistant/core as a code owner Feb 22, 2019

@wafflebot wafflebot bot added the in progress label Feb 22, 2019

@@ -160,8 +160,8 @@ def _load_file(hass, # type: HomeAssistant
sys.path.insert(0, hass.config.config_dir)
cache = hass.data[DATA_KEY] = {}

for index, path in enumerate('{}.{}'.format(base, comp_or_platform)
for base in base_paths):
for _, path in enumerate('{}.{}'.format(base, comp_or_platform)

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Feb 22, 2019

Member

If we don't need the index we don't need to use enumerate.

@fbradyirl

This comment has been minimized.

Copy link
Collaborator

commented Feb 22, 2019

LGTM. Will be great to get the pipeline working thanks @fabaff

@amelchio
Copy link
Contributor

left a comment

Thanks. Let's merge this so the build gets fixed.

@amelchio amelchio merged commit 3f29e91 into dev Feb 22, 2019

5 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 92.702%
Details

@delete-merged-branch delete-merged-branch bot deleted the loader branch Feb 22, 2019

@wafflebot wafflebot bot removed the in progress label Feb 22, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.