Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the velbus sync clock service #21308

Merged
merged 6 commits into from Mar 3, 2019

Conversation

Projects
None yet
4 participants
@Cereal2nd
Copy link
Contributor

commented Feb 22, 2019

Description:

This adds a new service to the velbus component. When calling this service it will do a 'sync clock' action from VelbusLink. It will synchronize the modules time with the system time of HA.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
Show resolved Hide resolved homeassistant/components/velbus/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/velbus/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/velbus/__init__.py Outdated
@Cereal2nd

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

can we get this one merged? or do we need something else?

Cereal2nd added some commits Feb 22, 2019

Show resolved Hide resolved homeassistant/components/velbus/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/velbus/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/velbus/__init__.py Outdated

@andrewsayre andrewsayre merged commit b985223 into home-assistant:dev Mar 3, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.01%) to 92.745%
Details

@ghost ghost removed the in progress label Mar 3, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.