Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for attribute existence for HS220 support #21309

Merged
merged 2 commits into from Feb 23, 2019

Conversation

rytilahti
Copy link
Member

Description:

The HS220 acts as a smartplug and does not currently contain is_color nor is_variable_color_temp attributes, causing this to crash on those devices.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost assigned rytilahti Feb 22, 2019
@ghost ghost added the in progress label Feb 22, 2019
@fabaff fabaff merged commit 492c3b2 into home-assistant:dev Feb 23, 2019
@ghost ghost removed the in progress label Feb 23, 2019
@rytilahti rytilahti deleted the fix_hs220_support branch February 24, 2019 19:59
@balloob balloob mentioned this pull request Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants