Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow google home component device tracker to be optional #21335

Merged
merged 1 commit into from Feb 23, 2019

Conversation

Projects
None yet
3 participants
@dshokouhi
Copy link
Contributor

dshokouhi commented Feb 22, 2019

Description:

Allow users to disable the device tracker so they can only use alarms and timers if they decide to do so. Can also be useful if several google homes are in close proximity of each other so they can decide which to use.

This is a non-breaking change as the default behavior has not been changed. Just a setting to disable it was added.

Related issue (if applicable): fixes # N/A

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8701

Example entry for configuration.yaml (if applicable):

googlehome:
  devices:
    - host: 192.168.1.2
      track_devices: False

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@rohankapoorcom
Copy link
Member

rohankapoorcom left a comment

Nice work!

@rohankapoorcom rohankapoorcom merged commit 2aa7bdb into home-assistant:dev Feb 23, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.712%
Details

@wafflebot wafflebot bot removed the in progress label Feb 23, 2019

@dshokouhi dshokouhi deleted the dshokouhi:google_home_device_tracker_optional branch Feb 23, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.