Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmartThings Switch platform power/energy enhancement #21375

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@andrewsayre
Copy link
Contributor

andrewsayre commented Feb 23, 2019

Description:

Enhances the SmartThings Switch platform to report power and energy utilization for metering devices.

Pull request in home-assistant.io with documentation: home-assistant/home-assistant.io#8713

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been updated to verify that the new code works.
@andrewsayre

This comment has been minimized.

Copy link
Contributor Author

andrewsayre commented Feb 25, 2019

@MartinHjelmare Hoping this is a quick one we can knock out. :)

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Looks good!

@MartinHjelmare MartinHjelmare merged commit 0ccbf61 into home-assistant:dev Feb 25, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 92.712%
Details

@wafflebot wafflebot bot removed the in progress label Feb 25, 2019

@andrewsayre andrewsayre deleted the andrewsayre:enhancement-smartthings-switch branch Feb 25, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.