Add target_temp_high/low and current_temperature #21393
Conversation
ghost
added
the
|
The coverage test failure doesn't seem related |
|
|
||
| ATTR_MAX_TEMP = 'max_temp' | ||
| ATTR_MIN_TEMP = 'min_temp' | ||
| ATTR_AWAY_MODE = 'away_mode' | ||
| ATTR_OPERATION_MODE = 'operation_mode' | ||
| ATTR_OPERATION_LIST = 'operation_list' | ||
| ATTR_TARGET_TEMP_HIGH = 'target_temp_high' |
There was a problem hiding this comment.
We shouldn't do this. If a water heater is set to auto, we should just assume it supports a high/low temp.
We should not copy the mistakes from the climate component.
There was a problem hiding this comment.
Unsure what you mean here. Maybe comment is on wrong line. You mean the support features? the attributes are needed to be able to display. But the SUPPORT_TARGET_* are probably pointless. If the AUTO mode have no target min/max, they should just return None.
There was a problem hiding this comment.
@balloob can you clarify?
There was a problem hiding this comment.
oh right, this should be on the support ones.
water_heater piggy back on climate(thermostat) component in gui, so these things are already supported by frontend for display purposes.
elupus
force-pushed
the
water_heater_current
branch
from
a244c38
to
789288c
Compare
Codecov Report
@@ Coverage Diff @@
## dev #21393 +/- ##
==========================================
- Coverage 94.15% 94.09% -0.06%
==========================================
Files 452 452
Lines 36809 36797 -12
==========================================
- Hits 34658 34625 -33
- Misses 2151 2172 +21
Continue to review full report at Codecov.
|
water_heater piggy back on climate(thermostat) component in gui,
so these things are already supported by frontend for display
purposes. (and sort of already works by using device_state_attributes)
Description:
This is an attempt to make the water_heater component a bit more usable without really touching
on the architectural issues with it.
Related issue (if applicable): partial #19093
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: