Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonos snapshot/restore #21411

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Member

amelchio commented Feb 24, 2019

Description:

The snapshot feature of the Sonos media player has been very unreliable when with_group is enabled (as it is by default).

I have redone the whole thing and in my testing it is now predictable. It restores groups correctly and the playing state is restored as well as the (unofficial) Sonos API allows. The functions now run under our topology lock and use the HA-based group cache to ensure consistency.

As everything is new, it does not make sense to compare to the old implementation but I will be happy to provide details on the new one if you have questions.

I have updated the documentation with some notes about the limitations of this feature.

Related issue (if applicable): fixes #14849, fixes #20861, fixes #21215

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8724

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.
@balloob
Copy link
Member

balloob left a comment

Ok to merge.

In the future, we should add permission check to the service call.

@balloob balloob merged commit 095a0d1 into home-assistant:dev Feb 25, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.726%
Details

@wafflebot wafflebot bot removed the in progress label Feb 25, 2019

@amelchio amelchio referenced this pull request Feb 28, 2019

Merged

Improve new Sonos snapshot/restore #21509

7 of 7 tasks complete

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.