Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of update interval for ness_alarm #21415

Merged

Conversation

Projects
None yet
4 participants
@nickw444
Copy link
Contributor

commented Feb 24, 2019

Description:

Allow users to configure the polling update interval of the component. ref: https://community.home-assistant.io/t/ness-dx8-dx16-alarm/23285/90?u=nickw444

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8720

Example entry for configuration.yaml (if applicable):

ness_alarm:
  host: alarm.home
  port: 8234
  update_interval:
    seconds: 10
  zones:
    - name: Garage
      id: 1
    - name: Storeroom
      id: 2

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@nickw444 nickw444 referenced this pull request Feb 24, 2019

Merged

Allow configuration of update_interval #8720

2 of 2 tasks complete

@fabaff fabaff changed the title ness_alarm: Allow configuration of update_interval Allow configuration of update interval for ness_alarm Feb 25, 2019

nickw444 added some commits Feb 25, 2019

@rohankapoorcom
Copy link
Member

left a comment

Thanks for using scan_interval instead of update_interval.

@rohankapoorcom rohankapoorcom merged commit 10e334c into home-assistant:dev Mar 4, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.004%) to 92.752%
Details

@ghost ghost removed the in progress label Mar 4, 2019

@nickw444 nickw444 deleted the nickw444:nwhyte-ness-alarm-update-interval branch Mar 4, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Mar 4, 2019

Merge branch 'dev' into current
* dev: (344 commits)
  Better output of workflow
  Upgrade youtube_dl to 2019.03.01 (home-assistant#21647)
  GitHub Workflow (home-assistant#21643)
  Fix actions with tox (home-assistant#21642)
  Replace travis (home-assistant#21641)
  Allow configuration of update interval for ness_alarm (home-assistant#21415)
  Updated frontend to 20190303.0
  Update translations
  Add storage helper to ZHA and use it for the device node descriptor (home-assistant#21500)
  Log exception occurred in WS service call command (home-assistant#21584)
  Fix calc next (home-assistant#21630)
  Expose create/delete cloudhook (home-assistant#21606)
  Return Netatmo climate operation_mode instead of boiler status (home-assistant#21633)
  Bump pyflunearyou to 1.0.3 (home-assistant#21634)
  fix derived rate, fixes home-assistant#20097 (home-assistant#21620)
  Add optional sender name for SendGrid (home-assistant#21610)
  Add 'app_name' property and 'apps' config entry to Fire TV (home-assistant#21601)
  Add device HMIP-eTRV-C to HomematicIP (home-assistant#21612)
  Bumping aioasuswrt (home-assistant#21627)
  SmartThings remove SmartApp/Automation on integration removal (home-assistant#21594)
  ...

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.