Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LCN sensor platform #21440

Merged
merged 1 commit into from Mar 16, 2019

Conversation

Projects
None yet
4 participants
@alengwenus
Copy link
Contributor

commented Feb 25, 2019

Description:

This adds the LCN sensor platform. It provides functionality to monitor various LCN hardware variables and non-bolean states. With proper configured hardware modules/sensors it is possible to measure temperatures, light intensities, voltages, currents, etc.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8734

Example entry for configuration.yaml (if applicable):

lcn:
  connections:
    - name: myhome
      host: 192.168.2.41
      port: 4114
      username: !secret lcn_username
      password: !secret lcn_password

  sensors:
    - name: Temperature
      address: myhome.s0.m7
      source: var3
      unit_of_measurement: celsius

    - name: Led6 state
      address: myhome.s0.m7
      source: led6

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@alengwenus alengwenus force-pushed the alengwenus:dev_lcn_sensor branch from 8e793a6 to f6e9eb5 Feb 27, 2019

@andrewsayre
Copy link
Member

left a comment

Thank you!

@andrewsayre andrewsayre merged commit d0365f5 into home-assistant:dev Mar 16, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.749%
Details

@ghost ghost removed the in progress label Mar 16, 2019

S0_INPUTS = ['S0INPUT1', 'S0INPUT2', 'S0INPUT3', 'S0INPUT4']

VAR_UNITS = ['', 'LCN', 'NATIVE',
'CELSIUS', '\u00b0CELSIUS', '\u00b0C',

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Mar 16, 2019

Member

We standardize some units like eg temperature units (TEMP_CELSIUS, TEMP_FAHRENHEIT). See const.py.

This comment has been minimized.

Copy link
@alengwenus

alengwenus Mar 16, 2019

Author Contributor

Thanks for the review!
I changed the temperature units to the standards. See the PR here: #22108
Once there are more stardadized units in Home Assistant, the code might need some rework to also support them. I'll keep watching..
I also updated the documentation accordingly: home-assistant/home-assistant.io#8734

@alengwenus alengwenus deleted the alengwenus:dev_lcn_sensor branch Mar 17, 2019

@balloob balloob referenced this pull request Apr 3, 2019

Merged

0.91.0 #22688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.