Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct binding for remotes and lights for ZHA #21498

Merged
merged 3 commits into from Feb 28, 2019

Conversation

Projects
None yet
3 participants
@dmulcahey
Copy link
Contributor

dmulcahey commented Feb 27, 2019

Adds the ability to directly bind remotes to bulbs (clusters 6 and 8 for now)

@homeassistant

This comment was marked as resolved.

Copy link

homeassistant commented Feb 27, 2019

Hello @dmulcahey,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@dmulcahey

This comment has been minimized.

Copy link
Contributor Author

dmulcahey commented Feb 27, 2019

I’ll fix the CLA issues when I am back at my Mac.

@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-direct-binding branch from 17553ce to 06f9669 Feb 27, 2019

@homeassistant

This comment was marked as resolved.

Copy link

homeassistant commented Feb 27, 2019

Hello @dmulcahey,

When attempting to inspect the commits of your pull request for CLA signature status among all authors we encountered commit(s) which were not linked to a GitHub account, thus not allowing us to determine their status(es).

The commits that are missing a linked GitHub account are the following:

Unfortunately, we are unable to accept this pull request until this situation is corrected.

Here are your options:

  1. If you had an email address set for the commit that simply wasn't linked to your GitHub account you can link that email now and it will retroactively apply to your commits. The simplest way to do this is to click the link to one of the above commits and look for a blue question mark in a blue circle in the top left. Hovering over that bubble will show you what email address you used. Clicking on that button will take you to your email address settings on GitHub. Just add the email address on that page and you're all set. GitHub has more information about this option in their help center.

  2. If you didn't use an email address at all, it was an invalid email, or it's one you can't link to your GitHub, you will need to change the authorship information of the commit and your global Git settings so this doesn't happen again going forward. GitHub provides some great instructions on how to change your authorship information in their help center.

    • If you only made a single commit you should be able to run
      git commit --amend --author="Author Name <email@address.com>"
      
      (substituting Author Name and email@address.com for your actual information) to set the authorship information.
    • If you made more than one commit and the commit with the missing authorship information is not the most recent one you have two options:
      1. You can re-create all commits missing authorship information. This is going to be the easiest solution for developers that aren't extremely confident in their Git and command line skills.
      2. You can use this script that GitHub provides to rewrite history. Please note: this should be used only if you are very confident in your abilities and understand its impacts.
    • Whichever method you choose, I will come by to re-check the pull request once you push the fixes to this branch.

We apologize for this inconvenience, especially since it usually bites new contributors to Home Assistant. We hope you understand the need for us to protect ourselves and the great community we all have built legally. The best thing to come out of this is that you only need to fix this once and it benefits the entire Home Assistant and GitHub community.

Thanks, I look forward to checking this PR again soon! ❤️

@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-direct-binding branch from 06f9669 to dfafd6b Feb 27, 2019

@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-direct-binding branch from dfafd6b to 4c0ced5 Feb 27, 2019

@@ -110,6 +119,26 @@
vol.Required(ATTR_CLUSTER_TYPE): str
})

WS_BIND_DEVICE = 'zha/devices/bind'

This comment has been minimized.

Copy link
@balloob

balloob Feb 27, 2019

Member

Please use the new websocket registration method

@websocket_api.websocket_command({
vol.Required('type'): 'system_health/info'
})
async def handle_info(hass: HomeAssistantType,

This comment has been minimized.

Copy link
@dmulcahey

dmulcahey Feb 28, 2019

Author Contributor

#21533 i will rebase this draft PR and convert that there if that is ok

@@ -244,6 +273,103 @@ def async_load_api(hass, application_controller, zha_gateway):
SCHEMA_WS_RECONFIGURE_NODE
)

@websocket_api.async_response
async def websocket_get_bindable_devices(hass, connection, msg):

This comment has been minimized.

Copy link
@balloob

balloob Feb 27, 2019

Member

Would be a lot nicer if we could define these outside of this function. Can't you get the gateway object from hass.data ?

This comment has been minimized.

Copy link
@dmulcahey

dmulcahey Feb 27, 2019

Author Contributor

I can make that work if it is preferable. Is there a technical reason to this or just a preference? Just curious on my end... I like to understand.

This comment has been minimized.

Copy link
@balloob

balloob Feb 27, 2019

Member

Preference:

  • Easier to read the code. Instead of reading it as F1…F2…F1…F3…F1 it's F1…F2…F3
  • Able to test smaller pieces of code

This comment has been minimized.

Copy link
@dmulcahey

dmulcahey Feb 27, 2019

Author Contributor

Makes perfect sense. Thanks for the explanation!

This comment has been minimized.

Copy link
@dmulcahey

dmulcahey Feb 28, 2019

Author Contributor

can I do this and the new registration style in another PR to minimize the scope? I'll do it right after...

This comment has been minimized.

Copy link
@dmulcahey

dmulcahey Feb 28, 2019

Author Contributor

how about I do this here: #21533 instead

dmulcahey added some commits Feb 17, 2019

cluster matching and binding apis
implement binding

callback

fix loop

fix loops

@dmulcahey dmulcahey force-pushed the dmulcahey:dm/zha-direct-binding branch from 13ad88c to c4e74a7 Feb 28, 2019

@balloob balloob merged commit 82bdd95 into home-assistant:dev Feb 28, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on dm/zha-direct-binding at 92.751%
Details

@wafflebot wafflebot bot removed the in progress label Feb 28, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.