Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce target_temperature_state_address for climate device #21541

Merged

Conversation

Projects
None yet
5 participants
@marvin-w
Copy link
Contributor

commented Feb 28, 2019

Description:

breaking change: users will need to update their configuration and change target_temperature_address to target_temperature_state_address.

Update xknx to version 0.10.0 which contains the following fixes and features:

  • (breaking change) Introduce target_temperature_state_address for climate devices (fixes #20106), users will need to update their configuration after this release and change target_temperature_address to target_temperature_state_address.
  • Connection config can now be configured in xknx.yml.
  • Introduce a configurable rate limit which limits the number of KNX telegrams sent to the bus per second.
  • Users who configured their lights via xknx.yml no longer need to manually set min_kelvin and max_kelvin (fixes #21251)

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8785

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Feb 28, 2019

@marvin-w marvin-w changed the title Update xknx to version 0.10.0 (breaking change) update xknx to version 0.10.0 Feb 28, 2019

@marvin-w marvin-w changed the title (breaking change) update xknx to version 0.10.0 Update xknx to version 0.10.0 Feb 28, 2019

@dgomes

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

If I understand properly this is a breaking change ?

The old behavior will break ?

@marvin-w

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

Yes. That's exactly why the label "breaking-change" was added.

From the description:

breaking change) Introduce target_temperature_state_address for climate devices (fixes #20106), users will need to update their configuration after this release and change target_temperature_address to target_temperature_state_address.

@dgomes

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

You should then update PR description and write a clear paragraph that will be used in the release blog post (this is a paragraph for users, not for devs)

@marvin-w

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

It's already there. Just use the 4 list items in the description as changelog

@dgomes

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

We will not use all those lines in the breaking changes section of the release...
I don't know knx, but this is the paragraph I would expect (not the current bullets, those are for devs):

breaking change: users will need to update their configuration and change target_temperature_address to target_temperature_state_address.

Is this enough for a normal user to read/fix ?

@marvin-w

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

Ah so you mean only for breaking change, then yes, that paragraph would be enough for users to know what to change

@dgomes

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

I copied my sentence into the description, but can you update the title ? The current one is not very descriptive on the impact of the version change...

@dgomes

dgomes approved these changes Mar 7, 2019

@marvin-w marvin-w changed the title Update xknx to version 0.10.0 Introduce target_temperature_state_address for climate device Mar 7, 2019

@marvin-w marvin-w changed the title Introduce target_temperature_state_address for climate device (breaking change) Introduce target_temperature_state_address for climate device Mar 7, 2019

@marvin-w

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

I updated the title

@dgomes dgomes changed the title (breaking change) Introduce target_temperature_state_address for climate device Introduce target_temperature_state_address for climate device Mar 7, 2019

@dgomes dgomes merged commit 5112f8f into home-assistant:dev Mar 7, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 92.756%
Details

@ghost ghost removed the in progress label Mar 7, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

@farmio farmio referenced this pull request Jul 18, 2019

Open

Climate does no longer work in HA 0.96 #218

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.