Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause/unpause services to RainMachine #21548

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
3 participants
@bachya
Copy link
Contributor

bachya commented Feb 28, 2019

Description:

This PR adds services to support pausing and unpausing watering activities in RainMachine.

To do this, bumps regenmaschine to 1.2.0. Changelog: https://github.com/bachya/regenmaschine/releases/tag/1.2.0

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8788

Example entry for configuration.yaml (if applicable):

rainmachine:
  controllers:
    - ip_address: !secret rainmachine_1_ip
      password: !secret rainmachine_1_password

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

bachya added some commits Feb 28, 2019

@balloob

balloob approved these changes Mar 1, 2019

@balloob balloob merged commit 326513a into home-assistant:dev Mar 1, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.002%) to 92.752%
Details

@wafflebot wafflebot bot removed the in progress label Mar 1, 2019

@bachya bachya deleted the bachya:rainmachine-pause branch Mar 3, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.