Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory optimization for logbook #21549

Merged
merged 1 commit into from Mar 2, 2019

Conversation

Projects
None yet
3 participants
@amelchio
Copy link
Member

amelchio commented Mar 1, 2019

Description:

As suggested by @balloob, this PR reworks the logbook a bit to keep less data in memory. This is done with a generator function that yields just the events that are not excluded rather than keeping the entire result set in memory (twice, I think).

In my limited testing, memory usage decreases significantly while the running time remains similar.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob

balloob approved these changes Mar 1, 2019

@balloob

This comment has been minimized.

Copy link
Member

balloob commented Mar 1, 2019

Beautiful! 🎉

@balloob balloob merged commit 0c8a31b into home-assistant:dev Mar 2, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.754%
Details

@wafflebot wafflebot bot removed the in progress label Mar 2, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.