Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word the tplink deprecation warning more strongly #21586

Merged
merged 1 commit into from Mar 2, 2019

Conversation

@amelchio
Copy link
Member

amelchio commented Mar 2, 2019

Description:

The current wording confused me when testing the beta.

A deprecation usually means that the feature still works but is on its way out. When it no longer works, it is obsolete ... but I picked a more friendly wording here :)

Example entry for configuration.yaml (if applicable):

switch:
  - platform: tplink
    host: 10.30.2.21

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.

@amelchio amelchio added this to the 0.89.0 milestone Mar 2, 2019

@amelchio amelchio requested a review from rytilahti as a code owner Mar 2, 2019

@wafflebot wafflebot bot added the in progress label Mar 2, 2019

@fabaff

fabaff approved these changes Mar 2, 2019

@Danielhiversen Danielhiversen merged commit 5eab869 into home-assistant:dev Mar 2, 2019

3 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Mar 2, 2019

balloob added a commit that referenced this pull request Mar 5, 2019

@balloob balloob referenced this pull request Mar 6, 2019

Merged

0.89.0 #21712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.