Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose create/delete cloudhook #21606

Merged
merged 2 commits into from Mar 4, 2019

Conversation

@balloob
Copy link
Member

commented Mar 3, 2019

Description:

Allow other components to check if a user is logged in to the cloud and to create/delete cloudwebhooks.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from home-assistant/core as a code owner Mar 3, 2019

@ghost ghost assigned balloob Mar 3, 2019

@ghost ghost added the in progress label Mar 3, 2019

@ghost ghost assigned robbiet480 Mar 3, 2019

@ghost ghost assigned andrewsayre Mar 3, 2019

@robbiet480 robbiet480 referenced this pull request Mar 3, 2019

Merged

mobile_app improvements #21607

3 of 3 tasks complete

@balloob balloob force-pushed the expose-create-cloudhook branch from 3bd9ad0 to 048d651 Mar 3, 2019

@balloob balloob added the cla-recheck label Mar 3, 2019

@balloob balloob force-pushed the expose-create-cloudhook branch from fdd68f5 to f67d405 Mar 3, 2019

Show resolved Hide resolved tests/components/cloud/test_init.py
Show resolved Hide resolved tests/components/cloud/test_init.py
Show resolved Hide resolved homeassistant/components/cloud/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/cloud/__init__.py
Show resolved Hide resolved homeassistant/components/cloud/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/cloud/__init__.py Outdated
Show resolved Hide resolved homeassistant/components/cloud/__init__.py Outdated

@balloob balloob force-pushed the expose-create-cloudhook branch from f67d405 to b9fa775 Mar 3, 2019

@balloob

This comment has been minimized.

Copy link
Member Author

commented Mar 3, 2019

Rolled back a few changes, cleaned it up, added some more tests.

@balloob balloob merged commit f5ed643 into dev Mar 4, 2019

5 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on expose-create-cloudhook at 92.756%
Details

@ghost ghost removed the in progress label Mar 4, 2019

@delete-merged-branch delete-merged-branch bot deleted the expose-create-cloudhook branch Mar 4, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Mar 4, 2019

Merge branch 'dev' into current
* dev: (344 commits)
  Better output of workflow
  Upgrade youtube_dl to 2019.03.01 (home-assistant#21647)
  GitHub Workflow (home-assistant#21643)
  Fix actions with tox (home-assistant#21642)
  Replace travis (home-assistant#21641)
  Allow configuration of update interval for ness_alarm (home-assistant#21415)
  Updated frontend to 20190303.0
  Update translations
  Add storage helper to ZHA and use it for the device node descriptor (home-assistant#21500)
  Log exception occurred in WS service call command (home-assistant#21584)
  Fix calc next (home-assistant#21630)
  Expose create/delete cloudhook (home-assistant#21606)
  Return Netatmo climate operation_mode instead of boiler status (home-assistant#21633)
  Bump pyflunearyou to 1.0.3 (home-assistant#21634)
  fix derived rate, fixes home-assistant#20097 (home-assistant#21620)
  Add optional sender name for SendGrid (home-assistant#21610)
  Add 'app_name' property and 'apps' config entry to Fire TV (home-assistant#21601)
  Add device HMIP-eTRV-C to HomematicIP (home-assistant#21612)
  Bumping aioasuswrt (home-assistant#21627)
  SmartThings remove SmartApp/Automation on integration removal (home-assistant#21594)
  ...

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.