Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional sender name for SendGrid #21610

Merged
merged 4 commits into from Mar 3, 2019

Conversation

Projects
None yet
3 participants
@srirams
Copy link
Contributor

commented Mar 3, 2019

Description:

Add optional email sender name for SendGrid. If not set, use "Home Assistant"

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link

commented Mar 3, 2019

Hi @srirams,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@srirams srirams referenced this pull request Mar 3, 2019

Merged

add optional sender name to sendgrid #8807

2 of 2 tasks complete

@srirams srirams changed the title Set "Home Assistant" as email sender name for SendGrid Add optional sender name for SendGrid Mar 3, 2019

@rohankapoorcom
Copy link
Member

left a comment

A couple changes and we can merge.

Show resolved Hide resolved homeassistant/components/notify/sendgrid.py
Show resolved Hide resolved homeassistant/components/notify/sendgrid.py Outdated
Show resolved Hide resolved homeassistant/components/notify/sendgrid.py Outdated
@rohankapoorcom
Copy link
Member

left a comment

Can be merged when build passes.

@rohankapoorcom rohankapoorcom merged commit 818776d into home-assistant:dev Mar 3, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.008%) to 92.758%
Details

@ghost ghost removed the in progress label Mar 3, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Mar 4, 2019

Merge branch 'dev' into current
* dev: (344 commits)
  Better output of workflow
  Upgrade youtube_dl to 2019.03.01 (home-assistant#21647)
  GitHub Workflow (home-assistant#21643)
  Fix actions with tox (home-assistant#21642)
  Replace travis (home-assistant#21641)
  Allow configuration of update interval for ness_alarm (home-assistant#21415)
  Updated frontend to 20190303.0
  Update translations
  Add storage helper to ZHA and use it for the device node descriptor (home-assistant#21500)
  Log exception occurred in WS service call command (home-assistant#21584)
  Fix calc next (home-assistant#21630)
  Expose create/delete cloudhook (home-assistant#21606)
  Return Netatmo climate operation_mode instead of boiler status (home-assistant#21633)
  Bump pyflunearyou to 1.0.3 (home-assistant#21634)
  fix derived rate, fixes home-assistant#20097 (home-assistant#21620)
  Add optional sender name for SendGrid (home-assistant#21610)
  Add 'app_name' property and 'apps' config entry to Fire TV (home-assistant#21601)
  Add device HMIP-eTRV-C to HomematicIP (home-assistant#21612)
  Bumping aioasuswrt (home-assistant#21627)
  SmartThings remove SmartApp/Automation on integration removal (home-assistant#21594)
  ...

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.