Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Netatmo climate operation_mode instead of boiler status #21633

Merged

Conversation

Projects
None yet
4 participants
@shanbs
Copy link
Contributor

shanbs commented Mar 3, 2019

Description:

This is two small fixes on netatmo/climate according to the reviewer's comments after the merging of #19407.

  1. Breaking change: return _operation_mode in function current_operation.
  2. Merge devices into one list before calling add_entities.

Breaking change:
current_operation will no longer return the the boiler status, but the operation_mode.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Merge the devices into one list and add into entries at once; Return …
…operation_mode instead of boiler status.

@MartinHjelmare MartinHjelmare changed the title Netatmo climate small fixes according to reviewer's comments Return Netatmo climate operation_mode instead of boiler status Mar 3, 2019

@MartinHjelmare
Copy link
Member

MartinHjelmare left a comment

Thanks!

@shanbs

This comment has been minimized.

Copy link
Contributor Author

shanbs commented Mar 3, 2019

Thanks!

Thanks to you!

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Mar 3, 2019

Please highlight the breaking change in a paragraph in the PR description for the release notes.

@shanbs

This comment has been minimized.

Copy link
Contributor Author

shanbs commented Mar 3, 2019

Please highlight the breaking change in a paragraph in the PR description for the release notes.

I modified the PR description, is it OK now?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Mar 4, 2019

Yes, thank you.

@MartinHjelmare MartinHjelmare merged commit c25cbcc into home-assistant:dev Mar 4, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls First build on netatmo-climate-merge-add-entries at 92.759%
Details

@wafflebot wafflebot bot removed the in progress label Mar 4, 2019

@shanbs shanbs deleted the shanbs:netatmo-climate-merge-add-entries branch Mar 4, 2019

mxworm added a commit to mxworm/home-assistant that referenced this pull request Mar 4, 2019

Merge branch 'dev' into current
* dev: (344 commits)
  Better output of workflow
  Upgrade youtube_dl to 2019.03.01 (home-assistant#21647)
  GitHub Workflow (home-assistant#21643)
  Fix actions with tox (home-assistant#21642)
  Replace travis (home-assistant#21641)
  Allow configuration of update interval for ness_alarm (home-assistant#21415)
  Updated frontend to 20190303.0
  Update translations
  Add storage helper to ZHA and use it for the device node descriptor (home-assistant#21500)
  Log exception occurred in WS service call command (home-assistant#21584)
  Fix calc next (home-assistant#21630)
  Expose create/delete cloudhook (home-assistant#21606)
  Return Netatmo climate operation_mode instead of boiler status (home-assistant#21633)
  Bump pyflunearyou to 1.0.3 (home-assistant#21634)
  fix derived rate, fixes home-assistant#20097 (home-assistant#21620)
  Add optional sender name for SendGrid (home-assistant#21610)
  Add 'app_name' property and 'apps' config entry to Fire TV (home-assistant#21601)
  Add device HMIP-eTRV-C to HomematicIP (home-assistant#21612)
  Bumping aioasuswrt (home-assistant#21627)
  SmartThings remove SmartApp/Automation on integration removal (home-assistant#21594)
  ...
@cogneato

This comment has been minimized.

Copy link

cogneato commented Mar 19, 2019

Actually, it isn't clear to me what a user needs to do to address this breaking change. Or does #19407 cover this already?

@shanbs

This comment has been minimized.

Copy link
Contributor Author

shanbs commented Mar 19, 2019

Actually, it isn't clear to me what a user needs to do to address this breaking change. Or does #19407 cover this already?

On top of the breaking changes I commented in #19407, this PR should add one more:

  1. Operation mode will return the selection of current operation mode (auto, manual, eco, heat, cool, or off) instead of the boiler status (heat or idle).

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.