Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify camera name in the logs #21653

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@arsaboo
Copy link
Contributor

commented Mar 4, 2019

Right now, a timeout results in a generic error message Timeout getting camera image. However, as the number of cameras in HA grows, it becomes difficult to isolate the culprit. This PR adds the camera name to the logs for users to identify the camera.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

@awarecan awarecan merged commit 5375510 into home-assistant:dev Mar 4, 2019

4 checks passed

Hound No violations found. Woof!
cla-bot Everyone involved has signed the CLA
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.001%) to 92.755%
Details

@ghost ghost removed the in progress label Mar 4, 2019

@arsaboo arsaboo deleted the arsaboo:camera1 branch Mar 4, 2019

@balloob balloob referenced this pull request Mar 20, 2019

Merged

0.90.0 #22216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.